Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cw20 token in cw4-stake #282

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Use Cw20 token in cw4-stake #282

merged 6 commits into from
Apr 26, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Apr 21, 2021 •
edited
Loading

Closes #143

  • Update implementation to support cw20 tokens everywhere.
  • Existing tests pass
  • Add tests for the cw20 use case

@ethanfrey ethanfrey marked this pull request as draft April 21, 2021 13:34
@ethanfrey ethanfrey marked this pull request as ready for review April 21, 2021 15:14
@ethanfrey ethanfrey requested a review from maurolacy April 21, 2021 15:14
@ethanfrey ethanfrey force-pushed the cw20-token-in-cw4-stake branch from edafe9b to 1aa084a Compare April 22, 2021 09:53
@maurolacy
Copy link
Contributor

Now reviewing.

maurolacy
maurolacy approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Will review tests later during the afternoon, and add isolated comments if I find anything.

contracts/cw4-stake/src/msg.rs Show resolved Hide resolved
contracts/cw4-stake/src/contract.rs Show resolved Hide resolved
contracts/cw4-stake/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw4-stake/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw4-stake/src/contract.rs Show resolved Hide resolved
@ethanfrey ethanfrey force-pushed the cw20-token-in-cw4-stake branch from 1aa084a to 078b7f2 Compare April 26, 2021 10:38
@ethanfrey ethanfrey mentioned this pull request Apr 26, 2021
Closed
@ethanfrey ethanfrey merged commit 475d5b5 into main Apr 26, 2021
@ethanfrey ethanfrey deleted the cw20-token-in-cw4-stake branch April 26, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cw20 support to token-weighted group
2 participants
@ethanfrey @maurolacy