Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary key / index key helpers #288

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Primary key / index key helpers #288

merged 6 commits into from
Apr 29, 2021

Conversation

maurolacy
Copy link
Contributor

Closes #277.

@maurolacy maurolacy requested a review from ethanfrey April 29, 2021 07:49
@maurolacy maurolacy self-assigned this Apr 29, 2021
ethanfrey
ethanfrey approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please update the index test to be a bit more clear.

packages/storage-plus/src/indexed_map.rs Outdated Show resolved Hide resolved
packages/storage-plus/src/indexes.rs Show resolved Hide resolved
@maurolacy maurolacy merged commit 0271884 into main Apr 29, 2021
@maurolacy maurolacy deleted the primary-key-index-key branch April 29, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees

@maurolacy maurolacy

Labels
storage plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve on indexed maps primary key / index keys helpers
2 participants
@maurolacy @ethanfrey