Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment job to CI #29

Merged
merged 10 commits into from
Aug 13, 2020
Merged

Add deployment job to CI #29

merged 10 commits into from
Aug 13, 2020

Conversation

webmaster128
Copy link
Member

No description provided.

@webmaster128 webmaster128 requested a review from ethanfrey August 11, 2020 14:20
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@webmaster128
Copy link
Member Author

Blocked by #30

@webmaster128 webmaster128 mentioned this pull request Aug 11, 2020
Closed
@ethanfrey
Copy link
Member

Also blocked by CosmWasm/optimizer#18

@ethanfrey ethanfrey mentioned this pull request Aug 11, 2020
Merged
@ethanfrey
Copy link
Member

I closed #30 and CosmWasm/optimizer#19 is ready for review (to fix the build errors)

ethanfrey
ethanfrey reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice setup. Hopefully I resolved the build bugs

.circleci/config.yml Outdated
@@ -1,15 +1,23 @@
version: 2
workflows:
version: 2
test:
# test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these all commented out?
I assume just as WIP while testing the other script, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in order to test the new job. You can revert or remove the commit "Dactivate test workflow" later

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@ethanfrey ethanfrey mentioned this pull request Aug 12, 2020
Closed
3 tasks
@ethanfrey
Copy link
Member

I updated this to rust-optimizer:0.10.0. Let's see if it works now

@ethanfrey
Copy link
Member

Note cw1-whitelist is super small, this is due to the fact the "library" feature is activated from the cw1-subkeys import, which affects the normal cw1_whitelist.wasm build as well. Since we don't use this contract, I can live with it, but time to revisit the build process a bit

webmaster128
webmaster128 commented Aug 13, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@ethanfrey ethanfrey marked this pull request as ready for review August 13, 2020 09:28
@ethanfrey ethanfrey merged commit a05187d into master Aug 13, 2020
@ethanfrey ethanfrey deleted the add-deployment-job branch August 13, 2020 09:57
@ethanfrey
Copy link
Member

Oops, I need to add a github token here. I will add it and try re-running the build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webmaster128 @CLAassistant @ethanfrey