Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkowned to vec u8 #290

Merged
merged 4 commits into from
May 3, 2021
Merged

Pkowned to vec u8 #290

merged 4 commits into from
May 3, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Apr 30, 2021 •
edited
Loading

Closes #199.

After some restructuring of the PrimaryKey and Prefixer trait impls, it was straightforward to replace PkOwned by Vec<u8>, and remove PkOwned entirely.

@maurolacy maurolacy requested a review from ethanfrey April 30, 2021 15:28
@maurolacy maurolacy self-assigned this Apr 30, 2021
ethanfrey
ethanfrey approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Should have done this months ago.

packages/storage-plus/src/keys.rs Show resolved Hide resolved
@ethanfrey ethanfrey merged commit fd2930b into main May 3, 2021
@ethanfrey ethanfrey deleted the pkowned-to-vec-u8 branch May 3, 2021 11:35
@maurolacy maurolacy mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees

@maurolacy maurolacy

Labels
storage plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage-plus: See if we can simplify PkOwned to Vec<u8>
2 participants
@maurolacy @ethanfrey