Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cw1 contracts #303

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Upgrade cw1 contracts #303

merged 3 commits into from
Jun 30, 2021

Conversation

uint
Copy link
Contributor

@uint uint commented Jun 28, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

orkunkl
orkunkl approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@orkunkl orkunkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure you run and fix warnings before merging:

  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo schema

@uint
Copy link
Contributor Author

uint commented Jun 29, 2021 •
edited
Loading

@orkunkl Fixed schemas for failing packages and the cw1 contracts. Hope I'm not going to cause conflicts with your work on the packages!

@uint
Copy link
Contributor Author

uint commented Jun 29, 2021

@orkunkl Also, remember I don't currently have permissions necessary to merge this myself!

@uint uint force-pushed the upgrade-cw1-contracts branch from 8770162 to 44c2387 Compare June 29, 2021 08:37
@orkunkl
Copy link
Contributor

orkunkl commented Jun 29, 2021

Cargo.lock needs to be updated.... This sucks.

@uint uint force-pushed the upgrade-cw1-contracts branch from 575af5a to bb82b95 Compare June 30, 2021 12:07
@uint uint force-pushed the upgrade-cw1-contracts branch from bb82b95 to 683e76d Compare June 30, 2021 12:09
@uint
Copy link
Contributor Author

uint commented Jun 30, 2021

Rebased.

@orkunkl orkunkl merged commit 057c984 into CosmWasm:v0.7.x Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orkunkl orkunkl orkunkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uint @CLAassistant @orkunkl