Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission bugs corrected in cw1-subkeys #354

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

hashedone
Copy link
Contributor

No description provided.

@hashedone hashedone requested a review from maurolacy July 26, 2021 09:52
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.

The test for this is in #343 I assume?

@@ -167,7 +167,7 @@ pub fn check_distribution_permissions(
return Err(ContractError::WithdrawPerm {});
}
}
s => panic!("Unsupported distribution message: {:?}", s),
_ => return Err(ContractError::UnsupportedMessage {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanfrey ethanfrey merged commit 7a6d61b into main Jul 26, 2021
@ethanfrey ethanfrey deleted the subkeys-permission-bug-fixes branch July 26, 2021 10:21
@hashedone
Copy link
Contributor Author

Yup, it is basically how I found the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants