Add transactional helper #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashedone
approved these changes
Jul 28, 2021
|
Yeah, those are just used in some tests. I guess I could remove or conditionally compile. |
ethanfrey
force-pushed
the
349-transaction-cleanup
branch
from
96ed35e to
ddc3223
Compare
maurolacy
reviewed
Jul 28, 2021
| let res = action(&mut cache, base)?; | ||
| cache.prepare().commit(base); | ||
| Ok(res) | ||
| } |
| api: self.api.deref(), | ||
| querier: QuerierWrapper::new(&querier), | ||
| }; | ||
| action(handler, deps, env) |
There was a problem hiding this comment.
Whoa, one action inside an action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #349