Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multitest events match wasmd #380

Merged
merged 8 commits into from
Aug 9, 2021
Merged

Multitest events match wasmd #380

merged 8 commits into from
Aug 9, 2021

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Aug 9, 2021 •
edited
Loading

Closes #348

Based on design from CosmWasm/wasmd#581

Ensure multi-test emits the same events as documented for x/wasm

  • Only emit wasm events if attribute is not-empty
  • Add custom execute, instantiate, migrate, reply events
  • Update all tests broken by refactoring
  • Test that reply callback gets expected events
  • Update README

@ethanfrey ethanfrey marked this pull request as ready for review August 9, 2021 13:42
@ethanfrey ethanfrey requested review from maurolacy and alpe August 9, 2021 13:42
@ethanfrey
Copy link
Member Author

Alex, I just added you FYI as we now provide an environment for the multi-test framework to match wasmd (based on the spec)

@ethanfrey ethanfrey merged commit 7798e97 into main Aug 9, 2021
@ethanfrey ethanfrey deleted the 348-multitest-events-match-wasmd branch August 9, 2021 14:38
@alpe
Copy link
Contributor

alpe commented Aug 10, 2021

very nice! 🌷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy Awaiting requested review from maurolacy

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multi-test: ensure event handling matches wasmd 0.18 implementation
2 participants
@ethanfrey @alpe