Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected submessage data response handling in multi-test #385

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

hashedone
Copy link
Contributor

No description provided.

@hashedone hashedone requested a review from ethanfrey August 10, 2021 09:03
if let Some(data) = res2.data {
orig.data = Some(data);
}
let reply_res = self._reply(api, router, storage, block, contract, reply)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes. We return the data from reply, not from the original sub message (which is only needed to fill into reply)

@ethanfrey ethanfrey merged commit 09e9e0f into document-submsg-data-failures Aug 10, 2021
@ethanfrey ethanfrey deleted the data-response-handling branch August 10, 2021 09:08
This was referenced Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants