Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CW1-whitelist execute multitest #402

Merged
merged 12 commits into from
Sep 8, 2021
Merged

CW1-whitelist execute multitest #402

merged 12 commits into from
Sep 8, 2021

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Sep 6, 2021 •
edited
Loading

closes #400

@ueco-jb ueco-jb self-assigned this Sep 6, 2021
@ueco-jb ueco-jb force-pushed the jakub/cw1-whitelist-execute-multitest branch from c88476a to 102c6b8 Compare September 7, 2021 14:23
@ueco-jb ueco-jb marked this pull request as ready for review September 7, 2021 14:47
@ueco-jb
Copy link
Contributor Author

ueco-jb commented Sep 7, 2021

I'm opening this for review. There's actually some stuff that I could change further (for example to not call store_code a second time in test), but I'll do it tommorow if necessary.

Changes outside of cw1-whitelist directory are not part of this PR and are here because for some reason last two merges from main dissapeared.

@ueco-jb ueco-jb force-pushed the jakub/cw1-whitelist-execute-multitest branch from a292e90 to c9a07d1 Compare September 8, 2021 06:57
@ueco-jb ueco-jb force-pushed the jakub/cw1-whitelist-execute-multitest branch from c9a07d1 to 182b4f7 Compare September 8, 2021 07:24
hashedone
hashedone requested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good changes, some stylistic notes.

contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
contracts/cw1-whitelist/src/integration_tests.rs
assert_matches!(suite.freeze(&second_contract), Ok(_));

let query_msg: QueryMsg = QueryMsg::AdminList {};
assert_matches!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like using assert_matches! here.

contracts/cw1-whitelist/src/integration_tests.rs Outdated Show resolved Hide resolved
@hashedone hashedone linked an issue Sep 8, 2021 that may be closed by this pull request
Test execute on cw1-whitelist contract #400
Closed
hashedone
hashedone approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One single detail to be corrected, just everything else ok. Merge yourself when remove obsolete pub.

@ueco-jb ueco-jb force-pushed the jakub/cw1-whitelist-execute-multitest branch from 15902c4 to 99a0570 Compare September 8, 2021 09:20
@ueco-jb ueco-jb merged commit 4252e23 into main Sep 8, 2021
@ueco-jb ueco-jb deleted the jakub/cw1-whitelist-execute-multitest branch September 8, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashedone hashedone hashedone approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

@maurolacy maurolacy Awaiting requested review from maurolacy

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test execute on cw1-whitelist contract
3 participants
@ueco-jb @hashedone @shanev