Add query helpers to Item and Map and use them in cw4 helpers #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
approved these changes
Sep 10, 2021
maurolacy
approved these changes
Sep 10, 2021
ethanfrey
force-pushed
the
376-item-query-helper
branch
from
854f1f0 to
ed645ab
Compare
ueco-jb
reviewed
Sep 13, 2021
packages/storage-plus/src/map.rs
Outdated
| @@ -123,6 +105,34 @@ where | |||
| } | |||
| } | |||
|
|
|||
| // TODO: move this to a better helpers location | |||
There was a problem hiding this comment.
Do you have something specific in mind? Maybe create an issue along the way?
There was a problem hiding this comment.
I will do this before merge.
Can't merge with a TODO (gotta make an issue for it first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #376
And also adds this functionality to Map. I didn't add any unit tests to this, but updated cw4 helpers to use this, which are covered in
cw3-flex-multitestand more. (A real use case).