Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatically generated changelog #426

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Add automatically generated changelog #426

merged 5 commits into from
Sep 16, 2021

Conversation

ueco-jb
Copy link
Contributor

@ueco-jb ueco-jb commented Sep 16, 2021 •
edited
Loading

@ueco-jb ueco-jb self-assigned this Sep 16, 2021
ethanfrey
ethanfrey reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start.
Two questions on how we can improve the output.

Also, please add a note to README on how to generate CHANGELOGs on release (document the command and any installation steps). So someone else can follow the same steps for v0.10.0.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
maurolacy
maurolacy reviewed Sep 16, 2021
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

README.md Show resolved Hide resolved
ethanfrey
ethanfrey approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool and thanks for the docs.

One last cleanup request and feel free to merge.

CHANGELOG.md Outdated Show resolved Hide resolved
@ueco-jb ueco-jb force-pushed the 421-add-auto-changelog branch from 8f6f3fb to c64652a Compare September 16, 2021 15:29
@ueco-jb ueco-jb merged commit 8b60238 into main Sep 16, 2021
@ueco-jb ueco-jb deleted the 421-add-auto-changelog branch September 16, 2021 15:29
@ueco-jb ueco-jb mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy left review comments

@ethanfrey ethanfrey ethanfrey approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees

@ueco-jb ueco-jb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auto-changelog generator
3 participants
@ueco-jb @ethanfrey @maurolacy