Add proper prefix_range helper when you want to iterate over the prefix space #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2021
hashedone
reviewed
Sep 22, 2021
|
|
||
| #[test] | ||
| #[cfg(feature = "iterator")] | ||
| fn composite_key_failure() { |
There was a problem hiding this comment.
I guess this test should be renamed (composite_key_range?) as it is never more showing the failure.
There was a problem hiding this comment.
yes, good point.
is that the only change request needed for approval?
There was a problem hiding this comment.
Sorry, I was commenting while still reading code :D But I guess yes.
hashedone
approved these changes
Sep 22, 2021
maurolacy
reviewed
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Fixes issue demonstrated in #429 (takes that commit as a starter)