Expose sudo powers on Router we give to Modules #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Sep 24, 2021
packages/multi-test/src/app.rs
Outdated
| @@ -665,6 +665,33 @@ where | |||
| } | |||
| } | |||
|
|
|||
| // TODO: extend this later to give privileged access to various modules | |||
There was a problem hiding this comment.
Just leaving a comment to create later issue for this one.
ueco-jb
approved these changes
Sep 28, 2021
Comment on lines
+881
to
+889
| type BasicRouter<ExecC = Empty, QueryC = Empty> = Router< | ||
| BankKeeper, | ||
| FailingModule<Empty, Empty>, | ||
| WasmKeeper<Empty, Empty>, | ||
| FailingModule<ExecC, QueryC, Empty>, | ||
| WasmKeeper<ExecC, QueryC>, | ||
| FailingStaking, | ||
| FailingDistribution, | ||
| > { | ||
| >; | ||
|
|
||
| fn mock_router() -> BasicRouter { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this need when trying to implement a custom router that could perform privileged operations on contracts.
It actually seems like it can be generalised for all "governance proposals" and such as done in the sdk, which is a privileged interface to modules.
I implemented this for Wasm::Sudo and Bank::Mint
I also added a test for a CustomModule that makes these permissions calls to mint tokens (also needed by staking module) and came across a lot of usability issues with the UI, which I was able to sort out.
I am getting a much higher confidence we can start plugging in external implementations.