Add tests for the claims controller #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the contribution. @maurolacy could you review this? |
maurolacy
reviewed
Oct 28, 2021
| assert_eq!(saved_claims.len(), 1); | ||
| assert_eq!(saved_claims[0].amount, (TEST_AMOUNT + 100).into()); | ||
| assert_eq!(saved_claims[0].release_at, Expiration::AtHeight(10)); | ||
| } |
There was a problem hiding this comment.
Similar to this, add a test where the cap allows to release only part of a claim (i.e. test_claim_tokens_with_cap_only_partial_amount_released()).
Let's say you have a mature claim for 100, but cap is 75.
Confirm / check that claim amounts are properly adjusted, and completed claims are removed.
There was a problem hiding this comment.
According to the code partial claims are not claimed at all. So in the case when the cap is less than either of the claims nothing will be claimed. Adding a test case based on that.
|
@maurolacy Fixed the tests! Thanks for taking a look. |
maurolacy
reviewed
Oct 29, 2021
| deps.as_mut().storage, | ||
| &Addr::unchecked("addr"), | ||
| &env.block, | ||
| Some((TEST_AMOUNT - 50).into()), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for all functions defined in the claims controller.