Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw1-subkeys: Migration example #525

Merged
merged 1 commit into from
Nov 4, 2021
Merged

cw1-subkeys: Migration example #525

merged 1 commit into from
Nov 4, 2021

Conversation

hashedone
Copy link
Contributor

@hashedone hashedone commented Nov 3, 2021

Closes #510
Closes #511

@@ -42,6 +42,9 @@ pub enum ContractError {

#[error("Allowance already expired while setting: {0}")]
SettingExpiredAllowance(Expiration),

#[error("Semver parsing error: {0}")]
SemVer(String),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be moved to StdError if we decide this is common one.

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice example. Thanks

@hashedone hashedone merged commit b230ea8 into main Nov 4, 2021
@hashedone hashedone deleted the 511-migration branch November 4, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate example Semver parsing / comparison
3 participants