Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split indexes impl into different files #526

Closed
wants to merge 17 commits into from
Closed

Split indexes impl into different files #526

wants to merge 17 commits into from

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Nov 3, 2021 •
edited
Loading

#461 follow-up / branched out. Closes #530.

uint and others added 16 commits November 3, 2021 07:05
@uint @maurolacy
Impl range_de and prefix_range_de for indexes
1767241
@uint @maurolacy
Test for UniqueIndex::range_de
12c67d9
@uint @maurolacy
rename deserialize_unique_* fns for clarity
c5988c4
@uint @maurolacy
Fix UniqueIndex::range_de
0bfadb4
@uint @maurolacy
test IndexedMap range_de with composite keys
a73de84
@maurolacy
Add missing prefix_de / sub_prefix_de to UniqueIndex
5aa6114
@maurolacy
Fix UniqueIndex prefix + range deserialization test
a47fd37
@maurolacy
Add clarifying comment
560ee89
@maurolacy
Invert deserialize unique index fn args for consistency
c4a4b05
@maurolacy
Add prefix_de / sub_prefix_de to MultiIndex
b6f381e
@maurolacy
MultiIndex example with String primary key
7252624
@maurolacy
MultIndex example using String also for index key
fcc74a3
@maurolacy
Fix: MultiIndex key deserializes to remaining key plus pk (Map-like)
bbcfba6
@maurolacy
Improve comment
ae6871e
@maurolacy
Add entry about index key deserialization
e00072f
@maurolacy
Split indexes impl into different files
eb41c9c
@maurolacy maurolacy force-pushed the 461-uniqueindex-range_de branch from e00072f to 067fb5f Compare November 9, 2021 14:37
ethanfrey
ethanfrey reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between this and #540 ?

@maurolacy
Copy link
Contributor Author

maurolacy commented Nov 15, 2021 •
edited
Loading

What is the difference between this and #540 ?

After rebasing, they are exactly the same. I guess with so many pending PRs, just forgot I already published / did it. Closing as duplicate.

@maurolacy maurolacy closed this Nov 15, 2021
@maurolacy maurolacy deleted the split-indexes-into-files branch November 15, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey left review comments

@uint uint Awaiting requested review from uint

@hashedone hashedone Awaiting requested review from hashedone

@ueco-jb ueco-jb Awaiting requested review from ueco-jb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurolacy @ethanfrey @uint