Fix min threshold in cw3-flex-multisig #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
changed the title
maurolacy
reviewed
Nov 6, 2021
|
Put on hold (low prio) till all matters are clarified. #528 (comment) |
ueco-jb
force-pushed
the
527-cw3multisig-fix-threshold-and-weight
branch
from
12375c4 to
15c69c0
Compare
ueco-jb
changed the title
ueco-jb
force-pushed
the
527-cw3multisig-fix-threshold-and-weight
branch
from
15c69c0 to
3f89079
Compare
ueco-jb
force-pushed
the
527-cw3multisig-fix-threshold-and-weight
branch
4 times, most recently
from
5d2b562 to
2b26ae1
Compare
maurolacy
reviewed
Nov 12, 2021
ueco-jb
force-pushed
the
527-cw3multisig-fix-threshold-and-weight
branch
3 times, most recently
from
30ec166 to
6078083
Compare
maurolacy
approved these changes
Nov 15, 2021
| @@ -934,6 +945,12 @@ mod tests { | |||
| ], | |||
| ); | |||
|
|
|||
| // VOTER1 cannot vote again | |||
| ) -> StdResult<Option<u64>> { | ||
| match height { | ||
| Some(height) => self.member_at_height(querier, member.to_string(), height.into()), | ||
| None => Map::new(MEMBERS_KEY).query(querier, self.addr(), member), |
There was a problem hiding this comment.
Wouldn't a raw query make sense here? Not sure, but, given that you already have querier, maybe the usage is simpler / clearer.
There was a problem hiding this comment.
Map::query does use a raw query under the hood (it calculated the final key in the other storage).
Querying at historical height does need smart query.
There was a problem hiding this comment.
NB: This code infers the type of Map completely? Based on self.addr() and the return value? Wow!
maurolacy
reviewed
Nov 15, 2021
maurolacy
reviewed
Nov 15, 2021
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
ueco-jb
force-pushed
the
527-cw3multisig-fix-threshold-and-weight
branch
from
95c8d9a to
8028c24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #527