Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range_de to IndexedSnapshotMap #543

Conversation

maurolacy
Copy link
Contributor

#461 follow-up. Adds keys_de / range_de to IndexedSnapshotMap. Also adds sub_/prefix_de for completeness.
(Addresses fourth part of #461 (comment)).

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in #542 please add a simple test case as a sanity check.

Then happy to review both in more detail

@maurolacy maurolacy force-pushed the 461-follow-up-add-prefix_de-indexed-map branch from 1e1bd3a to 501ab56 Compare November 15, 2021 15:13
@maurolacy maurolacy force-pushed the 461-follow-up-add-range_de-indexed-snapshot-map branch from 0d0b4f2 to 8788187 Compare November 15, 2021 15:13
@maurolacy maurolacy changed the title Add range de to IndexedSnapshotMap Add range_de to IndexedSnapshotMap Nov 18, 2021
@maurolacy maurolacy force-pushed the 461-follow-up-add-prefix_de-indexed-map branch from 501ab56 to bc10cb7 Compare November 19, 2021 16:28
Base automatically changed from 461-follow-up-add-prefix_de-indexed-map to 461-uniqueindex-range_de November 19, 2021 16:39
@maurolacy maurolacy force-pushed the 461-follow-up-add-range_de-indexed-snapshot-map branch 2 times, most recently from cd7e365 to e24ceac Compare November 19, 2021 19:10
@maurolacy maurolacy force-pushed the 461-follow-up-add-range_de-indexed-snapshot-map branch from e24ceac to 5561719 Compare November 22, 2021 09:08
@maurolacy maurolacy merged commit ce74d48 into 461-uniqueindex-range_de Nov 22, 2021
@maurolacy maurolacy deleted the 461-follow-up-add-range_de-indexed-snapshot-map branch November 22, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants