-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
range
to range raw
#576
Merged
Merged
range
to range raw
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove prefix()
Remove sub_prefix()
Remove UniqueIndex::prefix()
Remove MultiIndex::prefix() Adjust MultiIndex::no_prefix() trait bounds
…lti index Remove MultiIndex::sub_prefix
…ys/range in SnapshotMap
…ys/range in IndexedMap
…ys/range in IndexedSnapshotMap
…ys/range in UniqueIndex
…ys/range in MultiIndex
IndexedMap for consistency
SnapshotMap for consistency
IndexedSnapshotMap for consistency
UniqueIndex for consistency
MultiIndex for consistency
Refactor raw_range iterator
ethanfrey
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea.
Have not done a thorough review
ueco-jb
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460.
Lots of changes, but basically renaming
range
torange_raw
, andrange_de
torange
.range
in favour ofrange_de
, keepingrange
asrange_raw
.prefix_de
asprefix
, and remove the currentsprefix
. That is, noprefix_raw
impl, which will be confusing. That implies makingrange_raw
work with / overprefix_de
.Improve traits segregation over. (out of scope for this PR)Map
andPrefix
range-related methods, so that trait bounds are enforced only when strictly neededCould have chosen to provide two prefix functions,
prefix
andprefix_raw
, but opted instead to provide oneprefix
with two ranges over it,range
andrange_raw
, for simplicity of use. The only drawback is that if you want to prefix, you need to provide key deserialization impls for the involved keys, even if / when using onlyrange_raw
. This is reasonable IMO, as we are providing many of those impls already.Most interesting stuff is in the contracts, where we leverage the new key deserialization functionality for clarity and convenience.