-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link from coral to sandynet-1 #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing changed I see is space between pipes |
- is that right or am I missing something?
GH shows this only as big blob, but as far as I can see everything seems the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One line here is a good update.
The rest is some "markdown linter" that ran through the code. This could be good, but only if we have a standard that everyone uses.
If you pull out that one line into it's own PR, I will merge it happily.
If you want to make a new PR adding some markdown linter script to https://github.com/CosmWasm/cw-plus/tree/main/scripts and then running it (and checking in the new markdown), I would be happy to review it.
Maybe use something like https://github.com/CosmWasm/cosmwasm/blob/main/devtools/format_md.sh
?
@@ -47,7 +46,7 @@ many custom contracts. | |||
If you don't know what CosmWasm is, please check out | |||
[our homepage](https://cosmwasm.com) and | |||
[our documentation](https://docs.cosmwasm.com) to get more background. | |||
We are running a [public testnet](https://github.com/CosmWasm/testnets/blob/master/coralnet/README.md) | |||
We are running a [public testnet](https://github.com/CosmWasm/testnets/blob/master/sandynet-1/README.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for parsing through the linter junk to see the 1 liner. I'll look out for linter junk on future PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update this PR to be that one-line change? (So you can get the commit credit)
Happy for a follow up to ensure consistent linting, but it must be a script, not just your IDE (and mine is different)
Easier starting from scratch #617 |
Fix README.md link for public testnet