-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signed int key benchmarks #619
Conversation
Use same value for positive/negative calls
9905694
to
d5d255c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it.
I wonder if there's some feasible way to present those results in good way? Criterion prints a lot, and I personally use CircleCI as rare as possible.
.circleci/config.yml
Outdated
filters: | ||
branches: | ||
only: | ||
# Long living branches | ||
- main | ||
- /^[0-9]+\.[0-9]+$/ | ||
# 👇Add your branch here if benchmarking matters to your work | ||
- benchmarking | ||
- signed-int-key-bench |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for filtering, although I would still cut that list a little bit shorter.
Maybe remove release tag branches, since they are basically always directly derived from main
anyway?
You mean, besides That said, |
Just an exercise to confirm the different methods of doing
to-cw-bytes
are not incurring a significant performance loss.Not sure this needs to be merged. Published for reference.