Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed int key benchmarks #619

Merged
merged 8 commits into from
Jan 3, 2022
Merged

Signed int key benchmarks #619

merged 8 commits into from
Jan 3, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Jan 3, 2022

Just an exercise to confirm the different methods of doing to-cw-bytes are not incurring a significant performance loss.

Not sure this needs to be merged. Published for reference.

@maurolacy maurolacy force-pushed the signed-int-key-bench branch from 9905694 to d5d255c Compare January 3, 2022 07:41
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.
I wonder if there's some feasible way to present those results in good way? Criterion prints a lot, and I personally use CircleCI as rare as possible.

Comment on lines 31 to 39
filters:
branches:
only:
# Long living branches
- main
- /^[0-9]+\.[0-9]+$/
# 👇Add your branch here if benchmarking matters to your work
- benchmarking
- signed-int-key-bench
Copy link
Contributor

@ueco-jb ueco-jb Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for filtering, although I would still cut that list a little bit shorter.
Maybe remove release tag branches, since they are basically always directly derived from main anyway?

@maurolacy
Copy link
Contributor Author

I wonder if there's some feasible way to present those results in good way? Criterion prints a lot, and I personally use CircleCI as rare as possible.

You mean, besides cargo bench default output? There a number of options for displaying results (see https://doc.rust-lang.org/cargo/commands/cargo-bench.html#display-options), but now sure how to use them.

That said, -- --output-format bencher produces a terser output.

@maurolacy maurolacy merged commit cd29409 into main Jan 3, 2022
@maurolacy maurolacy deleted the signed-int-key-bench branch January 3, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants