Use ContractInfoResponse from cosmwasm_std #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
commented
Feb 2, 2022
| @@ -25,20 +25,6 @@ use cosmwasm_std::testing::mock_wasmd_attr; | |||
|
|
|||
| use anyhow::{bail, Context, Result as AnyResult}; | |||
|
|
|||
| // TODO: we should import this from cosmwasm-std, but cannot due to non_exhaustive so copy here | |||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)] | |||
| pub struct ContractInfoResponse { | |||
There was a problem hiding this comment.
This pub was never used, right? At least I did not find something.
There was a problem hiding this comment.
It was not. Maybe pub for test cases?
There was a problem hiding this comment.
Probably just copy/paste from the cosmwasm repo
ethanfrey
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, "due to non_exhaustive" really means we have no way to construct it. This is a feature initially because ContractInfoResponse instances are always provided to the contract developer and it should be hard to create them.
In CosmWasm/cosmwasm#1177 a constructor was added sets the two fields which have no default and use default values for the rest. This can be used now to remove the copied type.