packages: support custom queries

[uint]

In order to resolve confio/poe-contracts#36, it looks like we need the tgrade-valset contract to use TgradeQuery as the custom query type for Deps and DepsMut (currently it's Empty).

In order to do that, Admin needs to support custom query types that are not Empty in Deps/DepsMut.

[ethanfrey]

Ah, yes, now that I made Deps/DepsMut generic over the custom query type, we need to make controllers generic over that as well, not just Response.

I agree. Can you also update other controllers? (Possibly as a follow up)

[ethanfrey]

nice find

[ethanfrey]

Note that main is breaking, so after merge, you should make a new branch off of v0.11.1, back port this fix (and for the other controllers) and release a v0.11.2.

I don't think v0.12.0 is coming out so fast, so let's just patch the last stable version.

That said, those issues seem quite optional investigation work I threw in so they wouldn't be forgotten, so maybe just rename the v0.12.0 milestone to v0.13.0 and we cut a v0.12.0 soon? @maurolacy is managing this release I believe

[uint]

I agree. Can you also update other controllers? (Possibly as a follow up)

Happy to do that, should be easy enough.

[maurolacy]

OK with me. Only thing is that v0.12 will include type safe bounds, and it will require code migration.

Migration should be easy, though. And, there's already a MIGRATING entry for this.

[maurolacy]

LGTM.

[maurolacy]

As @ethanfrey says, you can either cherry pick this into a 0.11 branch (branched off from the latest 0.11 version tag) and release a new 0.11, or release 0.12 early. I for one would go for the 2nd, even when it'll require some code migration on the client repo(s).

Your call.

[ethanfrey]

Speaking of.. let me tag the v0.12.0-alpha2 release I prepared.
And then I will make one more PR I would like in a final v0.12.0. I will try to finish tonight, be able to review/merge tomorrow

[maurolacy]

Great. I can help with releasing 0.12 final if needed.

[uint]

I realized we might also need to update multitest with custom queries and I'm taking a shot at that, but it's not trivial.

[ethanfrey]

This is the relevant PR: #653

I would like that in before a v0.12.0 is tagged

[uint]

Okay, I tried to cover all of the /packages, multi-test included. Hopefully I didn't miss anything. Can you please take another look?

[uint]

As @ethanfrey says, you can either cherry pick this into a 0.11 branch (branched off from the latest 0.11 version tag) and release a new 0.11, or release 0.12 early. I for one would go for the 2nd, even when it'll require some code migration on the client repo(s).

I'd rather cut the new release than backport things, too. I guess for the migration there's nothing to do on my side if there's already a MIGRATING.md entry? Just that this is breaking for users?

[maurolacy]

LGTM.