Update changelog add upcoming #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
approved these changes
Mar 9, 2022
Comment on lines
+72
to
+73
| sed -i "s+\[Full Changelog\](https://github.com/CosmWasm/cw-plus/compare/\(.*\)\.\.\.HEAD)+[Full Changelog](https://github.com/CosmWasm/cw-plus/compare/$UPCOMING_TAG...HEAD)\n\n## [$UPCOMING_TAG](https://github.com/CosmWasm/cw-plus/tree/$UPCOMING_TAG) ($TODAY)\n\n[Full Changelog](https://github.com/CosmWasm/cw-plus/compare/\1...$UPCOMING_TAG)+" CHANGELOG.md | ||
| fi |
There was a problem hiding this comment.
Just an idea, you could try to add some validator here that sed actually worked (in case anything happens and for example changelog format slightly changes)
There was a problem hiding this comment.
That's an ugly line indeed. If I enable shellcheck here, which I tried, it complains about many issues with this script, and with abundant whining on this line in particular.
Will try to improve on it. Perhaps adding shellcheck, fixing some stuff, and silencing some other warnings.
On the other hand, if sed fails to match here (basically because there's no ...HEAD tag in the changelog, nothing happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
-u|--upcoming-tag <tag>option toupdate_changelog.sh, so that a new entry is created in CHANGELOG.md for the upcoming version tag.