Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add query_this_hook to hooks.rs #688

Merged
merged 5 commits into from
Jul 24, 2022
Merged

add query_this_hook to hooks.rs #688

merged 5 commits into from
Jul 24, 2022

Conversation

ishaan0x
Copy link
Contributor

Added a function to hooks.rs that enables devs to check if a specific hook exists. Small but hopefully useful :)

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ueco-jb
ueco-jb approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your contribution

packages/controllers/src/hooks.rs Outdated Show resolved Hide resolved
ueco-jb
ueco-jb reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually if you are interested in learning more Rust, I encourage you to add some tests for that implementation.
I see that we don't have any hooks tests yet (to be done...), but you still could do that as an excercise.

ishaan0x and others added 3 commits July 24, 2022 09:22
@ishaan0x
add query_this_hook to hooks.rs
af7e65c
@ishaan0x @ueco-jb
Update packages/controllers/src/hooks.rs
3f5f567 
Co-authored-by: Jakub Bogucki <software-solutions@tuta.io>
@maurolacy @ueco-jb
Update comment
0cb8ca7 
Co-authored-by: Jakub Bogucki <software-solutions@tuta.io>
@maurolacy maurolacy merged commit b2a1561 into CosmWasm:main Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@maurolacy maurolacy maurolacy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishaan0x @CLAassistant @maurolacy @ueco-jb