Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeyDeserialize trait public #692

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Make KeyDeserialize trait public #692

merged 3 commits into from
Mar 28, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Mar 27, 2022

Closes #691.

Also fixes trait bounds required for Map.

Fixing all the trait bounds requires a detailed analysis that is out of scope here. Will be done as part of CosmWasm/cw-storage-plus#8.

Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maurolacy maurolacy force-pushed the pub-key-deserialize branch from ccf55c8 to b07ce13 Compare March 28, 2022 10:19
@maurolacy maurolacy merged commit c5bc9bf into main Mar 28, 2022
@maurolacy maurolacy deleted the pub-key-deserialize branch March 28, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyDeserialize trait is private making custom keys and generics over keys not possible.
2 participants