Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage to CI #715

Merged
merged 9 commits into from
May 5, 2022
Merged

Add code coverage to CI #715

merged 9 commits into from
May 5, 2022

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented May 3, 2022

Closes #172.

Running this in all dev branches seems overkill. It also takes ~8 minutes to run.

@webmaster128
Copy link
Member

Running this in all dev branches seems overkill. It also takes ~8 minutes to run.

I think it's worth it because if you have codecov set up, it tells you if your PR has enough diff coverage. I had this in CosmWasm/cosmwasm#1286 where the tool made me add more tests to pass the codecov checks.

Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. I'd add a codecov config as otherwise you hardly have visibility of the results.

@maurolacy
Copy link
Contributor Author

Looks like a good start. I'd add a codecov config as otherwise you hardly have visibility of the results.

Nice. I'll copy / adapt it from cosmwasm.

@webmaster128
Copy link
Member

webmaster128 commented May 3, 2022

Also have a look at https://github.com/CosmWasm/cosmwasm/blob/main/codecov.yml, especially the first line avoids annoying GitHub comments from the codecov bot.

@maurolacy maurolacy force-pushed the 172-code-coverage branch from ada60bd to 240ddae Compare May 3, 2022 15:54
@maurolacy maurolacy force-pushed the 172-code-coverage branch from 240ddae to 966eab9 Compare May 3, 2022 16:09
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@e19fc2c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 966eab9 differs from pull request most recent head ef69301. Consider uploading reports for the commit ef69301 to get more accurate results

@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage        ?   92.04%           
=======================================
  Files           ?       98           
  Lines           ?    13446           
  Branches        ?        0           
=======================================
  Hits            ?    12376           
  Misses          ?     1070           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19fc2c...ef69301. Read the comment docs.

.circleci/config.yml Outdated Show resolved Hide resolved
Run coverage as part of tests
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurolacy maurolacy merged commit 119032e into main May 5, 2022
@maurolacy maurolacy deleted the 172-code-coverage branch May 5, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage tooling to the CI
3 participants