-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage to CI #715
Conversation
I think it's worth it because if you have codecov set up, it tells you if your PR has enough diff coverage. I had this in CosmWasm/cosmwasm#1286 where the tool made me add more tests to pass the codecov checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start. I'd add a codecov config as otherwise you hardly have visibility of the results.
Nice. I'll copy / adapt it from cosmwasm. |
Also have a look at https://github.com/CosmWasm/cosmwasm/blob/main/codecov.yml, especially the first line avoids annoying GitHub comments from the codecov bot. |
ada60bd
to
240ddae
Compare
240ddae
to
966eab9
Compare
Codecov Report
@@ Coverage Diff @@
## main #715 +/- ##
=======================================
Coverage ? 92.04%
=======================================
Files ? 98
Lines ? 13446
Branches ? 0
=======================================
Hits ? 12376
Misses ? 1070
Partials ? 0 Continue to review full report at Codecov.
|
Run coverage as part of tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #172.
Running this in all dev branches seems overkill. It also takes ~8 minutes to run.