Cw20 atomic swaps #72
Conversation
There was a problem hiding this comment.
Looks good.
I think some of the helpers to combine native and cw20 coins can be extended to make this even cleaner. But that is really for #73 - happy to see how you combined them already and I think we could do something similar with cw20-escrow as well.
I want to go through the test cases again to make sure it is all covered, but in general looks quite good.
| HandleMsg::Create(msg) => try_create(deps, env, msg), | ||
| HandleMsg::Create(msg) => try_create( | ||
| deps, | ||
| env.clone(), |
There was a problem hiding this comment.
Why clone? We never use it elsewhere
There was a problem hiding this comment.
It's needed because of the use of env.message.sent_funds, just below. I think it's because Coin (or the whole Env) doesn't currently implement the Copy trait.
I improved it a bit by cloning only the needed struct member.
I'll create an issue to implement the Copytrait for Coin/ Vec<Coin>.
There was a problem hiding this comment.
Coin contains strings, and cannot be Copy, only Clone.
I missed the other usage below... my bad. It was fine as it was, I just needed ☕
There was a problem hiding this comment.
No problem. I'll just close the issue I wrote regarding Copy coins then.
| } | ||
| } | ||
|
|
||
| pub fn try_receive<S: Storage, A: Api, Q: Querier>( |
| amount: cw20_coin.amount, | ||
| msg: Some(to_binary(&HandleMsg::Create(create)).unwrap()), | ||
| }; | ||
| let token_contract = cw20_coin.address; // TODO: Confirm |
| recipient: cw20_rcpt, | ||
| amount: cw20_coin.amount, | ||
| }; | ||
| assert_eq!( |
There was a problem hiding this comment.
Yup. I wonder if some of these asserts could be made easier with a few helpers, but not sure
| let env = mock_env("other_somebody", &[]); | ||
|
|
||
| // First, let's obtain the preimage from the logs of the release() transaction on Y | ||
| let preimage_log = &res.log[2]; |
Cw20 swap functionality.