-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proc macro package for automatic IndexList<T>
implementation
#737
Conversation
8e1ce60
to
3f29e20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
LTGM. Just some docs / comments style suggestions.
Seems the code coverage tool is being confused by the macro. We need to solve that before merging. |
Co-authored-by: Mauro Lacy <maurolacy@users.noreply.github.com>
Might we need an additional tarpaulin config flag to cover integration tests? |
Not sure how to address this. Also, please add the new storage-macro package to the README.md, under Utilities. |
This is just because this is a new package, that doesn't have previous runs. Merging now. Adding to README is not needed, because this is a private package. |
This will resolve #736
macro
crate feature oncw-storage-plus
is not enabled by default.cw-storage-macro
doesn't need to be published into crate.io because the macro is re-exported incw-storage-plus
package.