Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to unset minter in UpdateMinter message. #748

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

0xekez
Copy link
Contributor

@0xekez 0xekez commented Jul 6, 2022

This adds the ability to unset the minter in cw20's UpdateMinter message. Previously, the message only allowed for changing the minter to a new address.

I do not believe that a new release has been cut since the UpdateMinter message was added so, so far as I understand, this shouldn't break any compatibility guarantees.

Happy to take this elsewhere if this isn't wanted in the base cw20 specification.

@0xekez 0xekez force-pushed the zeke/minter-removal branch from 9526f9a to 0d4eae4 Compare July 6, 2022 08:20
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Very nicely spotted.
Thank you for contribution.

@ueco-jb
Copy link
Contributor

ueco-jb commented Jul 12, 2022

@ezekiiel Could you also add entry to CHANGELOG.md about this?

@0xekez
Copy link
Contributor Author

0xekez commented Jul 14, 2022

@ueco-jb done! thanks for the review.

@ueco-jb ueco-jb merged commit 8fd2904 into CosmWasm:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants