Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw20coin refactoring #78

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Cw20coin refactoring #78

merged 3 commits into from
Sep 10, 2020

Conversation

maurolacy
Copy link
Contributor

A small PR to move Cw20Coin to the cw20 package (closes #73).

Will also add coin normalization (#76) to cw20-atomic-swaps here.

@maurolacy maurolacy self-assigned this Sep 10, 2020
@maurolacy maurolacy marked this pull request as draft September 10, 2020 09:45
@maurolacy maurolacy requested a review from ethanfrey September 10, 2020 09:49
ethanfrey
ethanfrey approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reorg looks good. This could actually be merged as-is as just the de-dup.

And then another PR to add some helpers to it (like check for 0).
And another PR to handle the normalizing for Balance (I will check those PRs)

@maurolacy
Copy link
Contributor Author

OK.

@ethanfrey
Copy link
Member

If you agree for me to merge as is, please mark as non-draft. Then I can do it

@maurolacy maurolacy marked this pull request as ready for review September 10, 2020 11:34
@ethanfrey ethanfrey merged commit 193f8d0 into master Sep 10, 2020
@ethanfrey ethanfrey deleted the cw20coin-refactoring branch September 10, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cw20Coin duplication
2 participants
@maurolacy @ethanfrey