Add clear and is_empty methods to Map #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ueco-jb
reviewed
Sep 26, 2022
There was a problem hiding this comment.
Hey, thank you for that contribution!
Two comments:
- is there a reason why you created separate impl for that? I think it fits with same impl as
save,loadetc. so in your PR at line 112 - would you mind implementing this in
IndexedMaptype to keep feature parity?
|
@ueco-jb Thanks for the feedbacks! |
ueco-jb
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add two new utility methods to
Mapto make it more similar with the RustBTreeMapMaptrueif theMapdon't contains any elementTo implement the two methods I rely on the
iteratorfeature to get the keys of the elements inside the Map since I haven't find a better way to know the elements currently present inside theMap.