Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.15.1 #809

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Release 0.15.1 #809

merged 1 commit into from
Sep 27, 2022

Conversation

uint
Copy link
Contributor

@uint uint commented Sep 27, 2022

No description provided.

@uint uint requested a review from chipshort September 27, 2022 12:00
@uint uint marked this pull request as ready for review September 27, 2022 12:00
@uint uint requested a review from maurolacy September 27, 2022 12:15
CHANGELOG.md Outdated
Comment on lines 18 to 20
## [v0.15.1](https://github.com/CosmWasm/cw-plus/tree/v0.15.1) (2022-09-27)

[Full Changelog](https://github.com/CosmWasm/cw-plus/compare/v0.15.0...v0.15.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why twice the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18 is the title, line 20 is a link to all the commits between 0.15.0 and 0.15.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I see now. Huh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is, they are already in line 7 and 9

Copy link
Contributor Author

@uint uint Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Long story short, I suspect I got bitten by this bug:
github-changelog-generator/github-changelog-generator#992

I'm removing the changelog update commit, merging this, and then I'll update the changelog on main as suggested in the ticket, making sure the tag is there.

@uint uint merged commit 4d84263 into main Sep 27, 2022
@uint uint deleted the release-0.15.1 branch September 27, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants