-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cw1-subkeys: Point helper to smart contract version v0.2.1 #82
Conversation
@@ -346,10 +346,10 @@ const CW1 = (client: SigningCosmWasmClient): CW1Contract => { | |||
|
|||
const upload = async (): Promise<number> => { | |||
const meta = { | |||
source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.1.1/contracts/cw1-subkeys", | |||
source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.2.1/contracts/cw1-subkeys", | |||
builder: "cosmwasm/rust-optimizer:0.10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builder: "cosmwasm/rust-optimizer:0.10.1" | |
builder: "cosmwasm/workspace-optimizer:0.10.3" |
Should I apply this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we need to apply the meta change in every contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good to update.
But we are building with 0.10.2: https://github.com/CosmWasm/cosmwasm-plus/blob/master/.circleci/config.yml#L491
(Is 0.10.3 out?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to cosmwasm/workspace-optimizer:0.10.2
in both helper.ts files, then good to merge
@@ -346,10 +346,10 @@ const CW1 = (client: SigningCosmWasmClient): CW1Contract => { | |||
|
|||
const upload = async (): Promise<number> => { | |||
const meta = { | |||
source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.1.1/contracts/cw1-subkeys", | |||
source: "https://github.com/CosmWasm/cosmwasm-plus/tree/v0.2.1/contracts/cw1-subkeys", | |||
builder: "cosmwasm/rust-optimizer:0.10.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good to update.
But we are building with 0.10.2: https://github.com/CosmWasm/cosmwasm-plus/blob/master/.circleci/config.yml#L491
(Is 0.10.3 out?)
Just merged #83 Now I see why you changed this. |
First, merge #83 if no objections or blockers
Then release v0.2.1
Then merge this.