Unit tests for cw3-fixed-multisig #95
Conversation
|
Nice cleanup, and you convinved me about the 0 weight members. This should be documented in the README (TODO) |
maurolacy
force-pushed
the
cw3-fixed-multisig-tests
branch
from
0c40dbd to
dd99863
Compare
maurolacy
force-pushed
the
cw3-fixed-multisig-tests
branch
from
bab274e to
87a1fb2
Compare
maurolacy
force-pushed
the
cw3-fixed-multisig-tests
branch
from
87a1fb2 to
4d2c829
Compare
| // non-Open proposals cannot be voted | ||
| // Vote it again | ||
| let env = mock_env(VOTER5, &[]); | ||
| let res = handle(&mut deps, env, yes_vote); |
There was a problem hiding this comment.
After adding this test, I was left wondering that maybe it's a good idea to allow voting on Passed proposals: https://github.com/CosmWasm/cosmwasm-plus/blob/f979892bb7d32339769ad83ccb289e92e5a2f300/contracts/cw3-fixed-multisig/src/contract.rs#L165
That way, we can get better statistics on the final result of a given proposal. That is, despite a proposal having passed, it can have a large number of No / Veto votes (some of which could have been cast after it passed). Or, conversely, a proposal can have a larger adoption than the one reflected by the results; which currently "freeze" after it passes.
|
Thank you |
There are still some extra checks to do, but I think these now are acceptable unit tests.