-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Juno's changes into upstream #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I appreciate your effort to keep this module updated.
To contribute to the project, it would help to have PRs with a smaller scope that addresses a single issue.
) | ||
|
||
var DeniedDenoms = [1]string{"juno"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why "juno" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being removed in another PR from our fork. Resolved
@@ -0,0 +1,120 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this script called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a testing script to ensure the chain starts up correctly. Purely for development, not CI
@@ -0,0 +1,48 @@ | |||
export KEY="tf1" # wasm1hj5fveer5cjtn4wd6wstzugjfdxzl0xpvsr89g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this script called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a testing script to ensure the chain starts up correctly. Purely for development, not CI. I am removing this, only meant to be local oops
@@ -0,0 +1,28 @@ | |||
# This workflow will build a golang project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default build system is circleCI. Changing this, should be discussed in an issue first
@@ -4,7 +4,7 @@ package osmosis.tokenfactory.v1beta1; | |||
import "gogoproto/gogo.proto"; | |||
import "cosmos/base/v1beta1/coin.proto"; | |||
|
|||
option go_package = "github.com/osmosis-labs/osmosis/v12/x/tokenfactory/types"; | |||
option go_package = "github.com/CosmWasm/token-factory/x/tokenfactory/types"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Should hold off on merge until CosmosContracts#9 is in |
Closing this in favour of #20 |
No description provided.