Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to IBC v4 or v5 #960

Closed
alpe opened this issue Aug 25, 2022 · 10 comments · Fixed by #1088
Closed

Upgrade to IBC v4 or v5 #960

alpe opened this issue Aug 25, 2022 · 10 comments · Fixed by #1088
Labels
discussion M Estimated medium
Milestone

Comments

@alpe
Copy link
Contributor

alpe commented Aug 25, 2022

Tracking issue to upgrade the ibc-go dependency to v4

This release contains the fee middleware.

See migration guide

Versions currently used

@alpe alpe mentioned this issue Aug 25, 2022
@faddat
Copy link
Contributor

faddat commented Aug 25, 2022

Basically, as far as I understand things:

We will want ibc-go v4 OR ibc-go v3.2.0 for cosmos-sdk v0.45.7 -- there were some changes to support the sped-up DB, is my understanding. I also noticed a change that related to txCtx.R being included in gentx(...blabla..)

Also, I'd like to share an opinion-- my opinion is that CosmWasm represents the most advanced IBC application and that when possible, it makes sense to keep its IBC version rather aggressively up to date.

@alpe alpe moved this to 🆕 New in wasmd backlog Sep 23, 2022
@alpe alpe changed the title Upgrade to IBC v4 Upgrade to IBC v4 or v5 Sep 28, 2022
@alpe alpe moved this from 🆕 New to ❓ Needs more info in wasmd backlog Sep 30, 2022
@alpe alpe added this to the v0.30.0 milestone Oct 7, 2022
@the-frey
Copy link
Contributor

the-frey commented Oct 7, 2022

Would vote for v5. Do you have thoughts @jhernandezb ?

@the-frey
Copy link
Contributor

the-frey commented Oct 7, 2022

What we're seeing on testnets is ICA is causing a huge increase in relayer fees so as long as we're >v4 it's probably okay - nevertheless I agree with @faddat's reasoning that we should roll with v5

@jhernandezb
Copy link
Contributor

v5 will require moving to sdk 0.46, do we want to push for an sdk upgrade?

@the-frey
Copy link
Contributor

the-frey commented Oct 7, 2022

Ah I think (from memory) the notion was that wasmd would go straight to 0.47 when available, so that means v4? or is v4 also predicated on 46?

@jhernandezb
Copy link
Contributor

IBC v4 still depends on sdk 0.45 that will make it easier to upgrade
https://github.com/cosmos/ibc-go/blob/v4.1.0/go.mod#L10

@the-frey
Copy link
Contributor

the-frey commented Oct 7, 2022

Okay, I think then my vote would be v4 for 0.30.0 in that case.

image

@faddat
Copy link
Contributor

faddat commented Oct 23, 2022

Personally I am for version 6 and SDK 46 because we should not whip one another unnecessarily, you see, the dragon and it's berries are so fierce. They have delayed 47, and 46 adds useful stuff to the interchain accounts controller.

@ethanfrey
Copy link
Member

ibc-go v4.1.1 looks good: https://github.com/cosmos/ibc-go/blob/v4.1.1/go.mod#L10 (not 4.0 per their RELEASE NOTES)

@alpe alpe moved this from ❓ Needs more info to 🏄 v0.30 stretch goal in wasmd backlog Nov 9, 2022
@alpe
Copy link
Contributor Author

alpe commented Nov 9, 2022

Repository owner moved this from 🏄 v0.30 stretch goal to ✅ Done in wasmd backlog Nov 22, 2022
@alpe alpe removed this from wasmd backlog Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion M Estimated medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants