Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc-go v4.0.0 #940

Closed
wants to merge 19 commits into from
Closed

ibc-go v4.0.0 #940

wants to merge 19 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 15, 2022

This PR riffs on these PR's:

To create a v0.45.7 wasmd that also uses ibc-go v4.0.0 and would be most suited to Juno's v10 upgrade.

Thanks to David, author of #919

Note: if we merge this, then #937 should be closed. This is my preference for merging, so I've updated it, but please let me know if there's a preference for #937. Thanks!

Update

Since main is updated to v45.7, this branch now serves only as an upgrade to ibc-go v4.0.0

It also changes the version of golangci-lint from v1.47.0 to v1.47 so that we catch all go 1.18 compatible updates in golangci-lint (eg 1.47.*)

@faddat faddat requested a review from alpe as a code owner August 15, 2022 10:26
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #940 (3be9232) into main (d8ebe64) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   59.32%   59.32%           
=======================================
  Files          52       52           
  Lines        6630     6630           
=======================================
  Hits         3933     3933           
  Misses       2407     2407           
  Partials      290      290           
Impacted Files Coverage Δ
app/ante.go 62.50% <ø> (ø)
app/test_access.go 0.00% <ø> (ø)
x/wasm/keeper/handler_plugin.go 85.14% <ø> (ø)
x/wasm/keeper/handler_plugin_encoders.go 80.88% <ø> (ø)
x/wasm/keeper/ibc.go 77.77% <ø> (ø)
x/wasm/keeper/query_plugins.go 81.10% <ø> (ø)
x/wasm/ibc.go 69.51% <44.44%> (ø)
app/app.go 88.14% <100.00%> (ø)

@faddat faddat mentioned this pull request Aug 21, 2022
@alpe alpe added the spike Demo to showcase an idea. label Aug 25, 2022
@alpe
Copy link
Contributor

alpe commented Aug 25, 2022

Thanks a lot for this PR and showcasing the upgrade! 💪
I have not looked at the code yet but instead created #960 to discuss and track the ibc v4 upgrade and to get timing right.

@faddat faddat changed the title 457+ibc go 4.0.0 ibc-go v4.0.0 Aug 25, 2022
@ethanfrey ethanfrey modified the milestone: v0.30.0 Sep 6, 2022
@faddat
Copy link
Contributor Author

faddat commented Oct 26, 2022

We should not do this.

@faddat faddat closed this Oct 26, 2022
@larry0x
Copy link
Contributor

larry0x commented Nov 14, 2022

We should not do this.

@faddat why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Demo to showcase an idea.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants