-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ibc-go v4.0.0 #940
Closed
Closed
ibc-go v4.0.0 #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e637cf5.
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 59.32% 59.32%
=======================================
Files 52 52
Lines 6630 6630
=======================================
Hits 3933 3933
Misses 2407 2407
Partials 290 290
|
Closed
Thanks a lot for this PR and showcasing the upgrade! 💪 |
We should not do this. |
@faddat why not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR riffs on these PR's:
To create a v0.45.7 wasmd that also uses ibc-go v4.0.0 and would be most suited to Juno's v10 upgrade.
Thanks to David, author of #919
Note: if we merge this, then #937 should be closed. This is my preference for merging, so I've updated it, but please let me know if there's a preference for #937. Thanks!
Update
Since main is updated to v45.7, this branch now serves only as an upgrade to ibc-go v4.0.0
It also changes the version of golangci-lint from v1.47.0 to v1.47 so that we catch all go 1.18 compatible updates in golangci-lint (eg 1.47.*)