Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add factory contract scenario #1001

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Add factory contract scenario #1001

merged 1 commit into from
Sep 19, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 14, 2022

See #896
Implement flow diagram as unit test.

@jhernandezb can you confirm the workflow is correct?

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1001 (4a1d1b1) into main (8fc9855) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
+ Coverage   60.34%   60.37%   +0.03%     
==========================================
  Files          52       52              
  Lines        6430     6430              
==========================================
+ Hits         3880     3882       +2     
+ Misses       2263     2262       -1     
+ Partials      287      286       -1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 87.87% <0.00%> (+0.31%) ⬆️

@jhernandezb
Copy link
Contributor

I can confirm is working

@alpe alpe requested a review from pinosu September 15, 2022 11:29
@alpe
Copy link
Contributor Author

alpe commented Sep 15, 2022

Let's add this test for regression

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test! 💯

@alpe alpe merged commit e55db8b into main Sep 19, 2022
@alpe alpe deleted the 896_scenario branch September 19, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants