-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to wasmvm 1.1.1 #1012
Upgrade to wasmvm 1.1.1 #1012
Conversation
b2862be
to
cd1f8d1
Compare
cd1f8d1
to
76df37d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this dockerfile check, too! 💯
IN_GOMOD=$(go list -m github.com/CosmWasm/wasmvm | cut -d" " -f2 | cut -d"v" -f2) | ||
echo "wasmvm version in go.mod: $IN_GOMOD" | ||
if [[ "$IN_DOCKER" != "$IN_GOMOD" ]]; then | ||
echo "Mismatch of wasmvm versions detected" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 very nice check
fi | ||
- when: | ||
condition: | ||
equal: [ main, << pipeline.git.branch >> ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pushes to docker hub on main brach builds only, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that's the idea. Not 100 % tested but it is coming from the docs. At least in this PR the when
step is skipped because the condition is not met. Let's see what is happening on main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, it works. The latest
tag was publsihed from main: https://hub.docker.com/r/cosmwasm/wasmd/tags
Closes #1010