Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to wasmvm 1.1.1 #1012

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Upgrade to wasmvm 1.1.1 #1012

merged 5 commits into from
Sep 20, 2022

Conversation

webmaster128
Copy link
Member

Closes #1010

.circleci/config.yml Outdated Show resolved Hide resolved
@webmaster128
Copy link
Member Author

Bildschirmfoto 2022-09-20 um 13 15 13

Oh yeah, it works when I forget to update the Docker file :)

@webmaster128 webmaster128 marked this pull request as ready for review September 20, 2022 11:37
@webmaster128 webmaster128 requested a review from alpe as a code owner September 20, 2022 11:37
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this dockerfile check, too! 💯

IN_GOMOD=$(go list -m github.com/CosmWasm/wasmvm | cut -d" " -f2 | cut -d"v" -f2)
echo "wasmvm version in go.mod: $IN_GOMOD"
if [[ "$IN_DOCKER" != "$IN_GOMOD" ]]; then
echo "Mismatch of wasmvm versions detected"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 very nice check

fi
- when:
condition:
equal: [ main, << pipeline.git.branch >> ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pushes to docker hub on main brach builds only, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that's the idea. Not 100 % tested but it is coming from the docs. At least in this PR the when step is skipped because the condition is not met. Let's see what is happening on main.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, it works. The latest tag was publsihed from main: https://hub.docker.com/r/cosmwasm/wasmd/tags

@webmaster128 webmaster128 merged commit 5adb9e9 into main Sep 20, 2022
@webmaster128 webmaster128 deleted the wasmvm-1.1.1 branch September 20, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade wasmvm to 1.1.1
2 participants