-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dang/add tokenfactory module #1025
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 59.68% 59.79% +0.10%
==========================================
Files 52 52
Lines 6586 6599 +13
==========================================
+ Hits 3931 3946 +15
+ Misses 2367 2366 -1
+ Partials 288 287 -1
|
Thank you for your reviews! @alpe |
Hi guys, the osmosis team is well aware that we are using and promoting the token factory code in the ecosystem. In fact just about everybody that we work with is really keen on this particular pull request Okay so let me tell you a little bit about the motivation behind this pull request and also tell you like we can maintain it we work with Osmosis we spoke to like everybody about this pull request and basically everybody wants to have the token factory Juno wants to have the token factory, Eve wants to have the token factory, neutron even wants to have the token factory and it just seems an extremely sensible standard. And yes, it was absolutely copied from osmosis, so that contracts written for osmosis could be compatible in more places that was the explicit intent |
@faddat thanks for the additional context! I appreciate the effort and like us to continue the discussion on the issue. |
add module tokenfactory