Add weighted operations run simulation #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
alpe
reviewed
Nov 1, 2022
x/wasm/simulation/operations.go
Outdated
|
|
||
| msg := types.MsgUpdateAdmin{ | ||
| Sender: simAccount.Address.String(), | ||
| NewAdmin: simtypes.RandomAccounts(r, 1)[0].Address.String(), |
There was a problem hiding this comment.
Let's use simtypes.RandomAcc(r, accs) instead to not run dry
| msg := types.MsgInstantiateContract{ | ||
| Sender: simAccount.Address.String(), | ||
| Admin: simtypes.RandomAccounts(r, 1)[0].Address.String(), | ||
| Admin: adminAccount.Address.String(), |
app/params/weights.go
Outdated
| DefaultWeightMsgInstantiateContract int = 100 | ||
|
|
||
| DefaultWeightMsgStoreCode int = 100 | ||
| DefaultWeightMsgInstantiateContract int = 50 |
There was a problem hiding this comment.
Why flipping store and instantiate weights?
app/params/weights.go
Outdated
| DefaultWeightMsgExecuteContract int = 100 | ||
| DefaultWeightMsgUpdateAdmin int = 100 |
There was a problem hiding this comment.
I would expect this to happen quire rarely. How about 25?
app/params/weights.go
Outdated
| DefaultWeightMsgExecuteContract int = 100 | ||
| DefaultWeightMsgUpdateAdmin int = 100 | ||
| DefaultWeightMsgClearAdmin int = 100 |
There was a problem hiding this comment.
I would expect this to happen quire rarely. How about 10?
app/params/weights.go
Outdated
| DefaultWeightMsgExecuteContract int = 100 | ||
| DefaultWeightMsgUpdateAdmin int = 100 | ||
| DefaultWeightMsgClearAdmin int = 100 | ||
| DefaultWeightMsgMigrateContract int = 100 |
There was a problem hiding this comment.
I would expect more instantiations than migrations. How about 50?
x/wasm/simulation/operations.go
Outdated
| txCtx.SimAccount.PrivKey, | ||
| ) | ||
| if err != nil { | ||
| return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate mock tx"), nil, err |
There was a problem hiding this comment.
Suggested change
| return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate mock tx"), nil, err | |
| return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to generate tx"), nil, err |
x/wasm/simulation/operations.go
Outdated
| return simtypes.NoOpMsg(types.ModuleName, types.MsgMigrateContract{}.Type(), "unable to read response data"), nil, err | ||
| } | ||
|
|
||
| fmt.Printf("%v\n", result.Data[0].MsgType) |
x/wasm/simulation/operations.go
Outdated
|
|
||
| var wasmBz []byte | ||
| var err error | ||
| wasmBz, err = os.ReadFile("./../x/wasm/keeper/testdata/reflect_1_1.wasm") |
There was a problem hiding this comment.
I tried to avoid hard coding any contracts here. See L106-7.
As we only store reflect contracts you can just pick a different code id and drop the store code part.
There was a problem hiding this comment.
I have fixed to embed
alpe
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
- Coverage 59.28% 59.19% -0.09%
==========================================
Files 53 53
Lines 6722 6732 +10
==========================================
Hits 3985 3985
- Misses 2442 2452 +10
Partials 295 295
|
|
Let's remove some code to finish this: see 5697af6 |
Got it :3 tysm!!! |
NoahSaso
pushed a commit
to NoahSaso/wasmd
that referenced
this pull request
Dec 2, 2022
* add WeightedOperations msg update admin * add check contract info condition * add fnc simulate migrate * add weights operations migrate contract * fix simulation msg update admin * add simulation.NewWeightedOperation * add sml msg clear admin * fix lint * remove msg migrate * change admin to use test account * add migrate * add new contract for simulation migrate * correct return log * Polish SimulateMsgMigrateContract Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Magicloud
pushed a commit
to fpco/wasmd
that referenced
this pull request
Jan 13, 2023
* add WeightedOperations msg update admin * add check contract info condition * add fnc simulate migrate * add weights operations migrate contract * fix simulation msg update admin * add simulation.NewWeightedOperation * add sml msg clear admin * fix lint * remove msg migrate * change admin to use test account * add migrate * add new contract for simulation migrate * correct return log * Polish SimulateMsgMigrateContract Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
conorpp
pushed a commit
to wormhole-foundation/wasmd
that referenced
this pull request
Feb 1, 2023
* add WeightedOperations msg update admin * add check contract info condition * add fnc simulate migrate * add weights operations migrate contract * fix simulation msg update admin * add simulation.NewWeightedOperation * add sml msg clear admin * fix lint * remove msg migrate * change admin to use test account * add migrate * add new contract for simulation migrate * correct return log * Polish SimulateMsgMigrateContract Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #797
add operations run simulation for
add new test contract for simulation migrate contract