Allow better override of wasmVM in x/wasm keeper #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
reviewed
Jul 10, 2023
| @@ -63,6 +59,16 @@ func NewKeeper( | |||
| for _, o := range opts { | |||
| o.apply(keeper) | |||
| } | |||
| // only set the wasmvm if no one set this in the options | |||
| // NewVM does a lot, so better not to create it and silently drop it. | |||
There was a problem hiding this comment.
Thanks for bringing this up! Unfortunately, the implementation conflicts with the WithWasmEngineDecorator now that requires the object to exist.
I will come up with some solution
|
Hey guys, I want to mention -- I susepct that some of this is actually addressed by moving to wazero, but I don't really have a decent starting place. The thinking is like this:
therefore move to a pure go way of running the wasm. |
|
@faddat thanks for the head up! The use case Ethan wants to solve is:
|
Add post vm options
Codecov Report
@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
+ Coverage 58.17% 58.23% +0.05%
==========================================
Files 64 64
Lines 8460 8475 +15
==========================================
+ Hits 4922 4935 +13
- Misses 3130 3131 +1
- Partials 408 409 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code always creates one VM and then possibly overrides it with the options. However, creating the wasmVm will also create directories and initialize Rust structs that are not cleanly deleted. It would be better to never create it in the first place if it is overridden later.
This PR pushes the initialization towards the end of NewKeeper for this. A concrete use-case is in creating a wasmvm.VM externally and passing it in for more control, which will likely be necessary with ibc wasm light client.