Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit CLI and system tests #1627

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Revisit CLI and system tests #1627

merged 2 commits into from
Sep 15, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Sep 15, 2023

To fix TestGrantStoreCodePermissionedChain

@alpe alpe requested a review from pinosu September 15, 2023 10:37
@codecov
Copy link

codecov bot commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #1627 (c7c6a5a) into grant_system_test (e15f052) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

❗ Current head c7c6a5a differs from pull request most recent head c27f7db. Consider uploading reports for the commit c27f7db to get more accurate results

Impacted file tree graph

@@                  Coverage Diff                  @@
##           grant_system_test    #1627      +/-   ##
=====================================================
- Coverage              56.73%   56.58%   -0.16%     
=====================================================
  Files                     64       64              
  Lines                   8883     8904      +21     
=====================================================
- Hits                    5040     5038       -2     
- Misses                  3454     3476      +22     
- Partials                 389      390       +1
Files Changed Coverage Δ
x/wasm/client/cli/tx.go 14.92% <0.00%> (-0.79%) ⬇️

... and 1 file with indirect coverage changes

pinosu
pinosu approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💯

@alpe alpe merged commit c5a9537 into grant_system_test Sep 15, 2023
2 of 3 checks passed
alpe added a commit that referenced this pull request Sep 15, 2023
@pinosu @alpe
Add grant system tests (#1626)
6a2bffd 
* Add grant system tests

* Add unpermissioned chain test case

* Fix tests

* Update cli and fix feedbacks

* Revisit CLI and system tests (#1627)

* Restructure CLI; fix system test

* Review feedback

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
@alpe alpe deleted the grant_system_test_review branch September 18, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu