Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gov v1beta1 dependencies and deprecated proposals #1645

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Remove gov v1beta1 dependencies and deprecated proposals #1645

merged 3 commits into from
Oct 4, 2023

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Oct 2, 2023 •
edited
Loading

Part of #1608

@pinosu pinosu changed the base branch from main to releases/v0.4x October 2, 2023 09:49
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #1645 (220baf8) into releases/v0.4x (3f634a3) will increase coverage by 0.88%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           releases/v0.4x    #1645      +/-   ##
==================================================
+ Coverage           56.67%   57.56%   +0.88%     
==================================================
  Files                  64       62       -2     
  Lines                9011     8078     -933     
==================================================
- Hits                 5107     4650     -457     
+ Misses               3510     3041     -469     
+ Partials              394      387       -7
Files Coverage Δ
app/app.go 86.41% <ø> (ø)
x/wasm/types/codec.go 100.00% <ø> (ø)
x/wasm/types/test_fixtures.go 63.56% <ø> (-17.47%) ⬇️

... and 2 files with indirect coverage changes

@pinosu pinosu marked this pull request as ready for review October 2, 2023 12:56
@pinosu pinosu requested a review from alpe as a code owner October 2, 2023 12:56
alpe
alpe approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@alpe alpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Great to gov v1 integration complete now 🏅

@alpe alpe added backport/main Backport patches to main branch and removed backport/main Backport patches to main branch labels Oct 4, 2023
@pinosu pinosu merged commit cb9f569 into releases/v0.4x Oct 4, 2023
16 checks passed
@pinosu pinosu deleted the 1608-remove_govv1beta1 branch October 4, 2023 07:32
emidev98 pushed a commit to terra-money/wasmd that referenced this pull request Nov 10, 2023
@pinosu @emidev98
Revert "Remove gov v1beta1 dependencies and deprecated proposals (Cos…
21809bc 
…mWasm#1645)"

This reverts commit cb9f569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe alpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinosu @alpe