Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanups and comments #1712

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Minor cleanups and comments #1712

merged 2 commits into from
Nov 13, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 13, 2023

Minor cleanups to remove unused code or make smaller diff to upstream code

@alpe alpe requested a review from pinosu November 13, 2023 12:55
pinosu
pinosu approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe marked this pull request as ready for review November 13, 2023 13:07
@alpe alpe merged commit 6f8c0a9 into main Nov 13, 2023
10 of 11 checks passed
@alpe alpe deleted the upgrade_sdk_50_feedback branch November 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @pinosu