Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gov v1beta1 support for legacy propsals #1715

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Fix gov v1beta1 support for legacy propsals #1715

merged 5 commits into from
Nov 15, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 14, 2023 •
edited
Loading

Resolves #1713

@alpe alpe requested a review from pinosu November 14, 2023 11:03
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

Merging #1715 (de0e0a9) into main (6f8c0a9) will decrease coverage by 0.14%.
The diff coverage is 54.28%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
- Coverage   57.42%   57.29%   -0.14%     
==========================================
  Files          61       63       +2     
  Lines        8134     8820     +686     
==========================================
+ Hits         4671     5053     +382     
- Misses       3025     3286     +261     
- Partials      438      481      +43
Files Coverage Δ
x/wasm/types/codec.go 58.82% <55.55%> (-2.72%) ⬇️
x/wasm/keeper/proposal_handler_legacy.go 55.77% <55.77%> (ø)
x/wasm/types/proposal_legacy.go 53.56% <53.56%> (ø)

... and 4 files with indirect coverage changes

@alpe alpe added the backport/v0.4x backport patches to sdk47 release branch label Nov 14, 2023
@alpe alpe added this to the v0.50.0 milestone Nov 14, 2023
pinosu
pinosu approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alpe alpe merged commit 2a82e35 into main Nov 15, 2023
15 of 16 checks passed
@alpe alpe deleted the 1713_govv1beta1 branch November 15, 2023 07:29
mergify bot pushed a commit that referenced this pull request Nov 15, 2023
@alpe @mergify
Fix gov v1beta1 support for legacy propsals (#1715)
f8f1ff4 
* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias

(cherry picked from commit 2a82e35)

# Conflicts:
#	x/wasm/types/tx.pb.go
@mergify mergify bot mentioned this pull request Nov 15, 2023
Merged
alpe added a commit that referenced this pull request Nov 15, 2023
@mergify @alpe
Fix gov v1beta1 support for legacy propsals (backport #1715) (#1716)
2d9c98f 
* Fix gov v1beta1 support for legacy propsals (#1715)

* Revert "Remove gov v1beta1 dependencies and deprecated proposals (#1646)"

This reverts commit e0da419.

* Rename legacy propsal files

* Ensure gov store support for v1beta1 types

* Linter

* Cleanup alias

(cherry picked from commit 2a82e35)

# Conflicts:
#	x/wasm/types/tx.pb.go

* Rengenerate from proto; formatting

* Make test compile with v0.4x branch

---------

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
da1suk8 added a commit to da1suk8/wasmd that referenced this pull request Mar 18, 2024
@da1suk8
fix: changed references from govtypes to v1beta
5bb5af6 
See: CosmWasm#1715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinosu pinosu pinosu approved these changes

Assignees
No one assigned
Labels
backport/v0.4x backport patches to sdk47 release branch
Projects
None yet
Milestone
v0.50.0
Development

Successfully merging this pull request may close these issues.

Provide migration code for gov beta1 to v1
2 participants
@alpe @pinosu