Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrate legacy params #1729

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Fix migrate legacy params #1729

merged 3 commits into from
Nov 21, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Nov 16, 2023

Resolves #1725

See # 1732

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #1729 (c90a48c) into main (3b6512c) will decrease coverage by 2.37%.
Report is 2 commits behind head on main.
The diff coverage is 29.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
- Coverage   57.25%   54.89%   -2.37%     
==========================================
  Files          63       64       +1     
  Lines        8818     9640     +822     
==========================================
+ Hits         5049     5292     +243     
- Misses       3287     3822     +535     
- Partials      482      526      +44     
Files Coverage Δ
app/upgrades.go 85.00% <100.00%> (+6.95%) ⬆️
x/wasm/migrations/v2/store.go 75.00% <100.00%> (+15.00%) ⬆️
x/wasm/types/params.go 74.19% <100.00%> (+1.91%) ⬆️
app/app.go 85.66% <86.66%> (+1.31%) ⬆️
x/wasm/migrations/v2/params_legacy.go 68.57% <68.57%> (ø)
x/wasm/migrations/v2/legacy_types.go 21.81% <21.81%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

x/wasm/keeper/migrations_integration_test.go Show resolved Hide resolved
x/wasm/migrations/v2/params_legacy.go Show resolved Hide resolved
x/wasm/migrations/v2/store_test.go Show resolved Hide resolved
@alpe alpe marked this pull request as ready for review November 20, 2023 16:34
@alpe alpe requested a review from pinosu November 20, 2023 16:38
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Nice to see also the example for upgrades from 33 to 50. Very useful 💯
Definitely good to mention it in the CHANGELOG 👍

@alpe alpe merged commit dffa321 into main Nov 21, 2023
14 of 16 checks passed
@alpe alpe deleted the 1725_legacy_params branch November 21, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module migration fails when code upload access is set to OnlyAddress
2 participants