Add auto-gzip contracts in cli when uploading #19
Conversation
x/wasm/client/utils/utils.go
Outdated
| return false | ||
| } | ||
|
|
||
| in := io.LimitReader(bytes.NewReader(input), maxSize) |
There was a problem hiding this comment.
Alex does this to maintain a stream for his reader functionality. You can just do a bytes.Equal(input[:3], gzipIdent)
The function is correct and nice code organization btw. Just could be simpler
There was a problem hiding this comment.
Oh, and compare on maxSize as well I guess
x/wasm/client/utils/utils.go
Outdated
| // IsWasm checks if the file contents are of wasm binary | ||
| func IsWasm(input []byte) bool { | ||
| if len(input) < 3 { | ||
| return false |
There was a problem hiding this comment.
Same as above. Function looks good, but could be simpler.
|
|
||
| // GzipIt compresses the input ([]byte) | ||
| func GzipIt(input []byte) ([]byte, error) { | ||
| // Create gzip writer. |
| @@ -57,6 +59,17 @@ func StoreCodeCmd(cdc *codec.Codec) *cobra.Command { | |||
| return err | |||
| } | |||
|
|
|||
| // gzip the wasm file | |||
| if wasmUtils.IsWasm(wasm) { | |||
| wasm, err = wasmUtils.GzipIt(wasm) | |||
|
@ethanfrey updated all the changes. It is r4r |
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 59.2% 59.38% +0.18%
==========================================
Files 11 12 +1
Lines 929 943 +14
==========================================
+ Hits 550 560 +10
- Misses 329 331 +2
- Partials 50 52 +2
Continue to review full report at Codecov.
|
| } | ||
|
|
||
| // IsWasm checks if the file contents are of wasm binary | ||
| func IsWasm(input []byte) bool { |
There was a problem hiding this comment.
Thanks for the cleanup, so simple
Closes: #17 Depends on: cosmos/cosmos-sdk#4470
Fixes: #18
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdReviewed
Files changedin the github PR explorerFor Admin Use: